Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Production Release | Dec Week 2 #6849

Merged
merged 10 commits into from
Dec 11, 2023
Merged

Production Release | Dec Week 2 #6849

merged 10 commits into from
Dec 11, 2023

Conversation

gigincg
Copy link
Member

@gigincg gigincg commented Dec 11, 2023

WHAT

🤖[deprecated] Generated by Copilot at 05549b5

This pull request improves the reliability and consistency of the cypress tests for various pages of the application. It mainly does this by clearing the local storage of filters before each test case, using custom commands or clear buttons. It also fixes some minor issues with the location name and the filter menu visibility. It affects the files cypress/e2e/*_spec/*.cy.ts.

Proposed Changes

  • Fixes #issue?
  • Change 1
  • Change 2
  • More?

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖[deprecated] Generated by Copilot at 05549b5

  • Clear any previously applied filters from the local storage before each test case to avoid conflicts or inconsistencies (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)
  • Clear all the filters from the facility_creation.cy.ts page by clicking on the clear button for each filter (link)
  • Select the location type as ICU for the facility location in locations.cy.ts (link)
  • Move the code that clears the filters from the afterEach hook to the beforeEach hook in filter.cy.ts (link)
  • Click on the filters button before selecting any filter in filter.cy.ts (link, link, link, link)
  • Remove the code that clicks on the filters button after selecting a filter in filter.cy.ts (link, link)
  • Replace the code that clicks on the filters button and then the clear button with a custom command in filter.cy.ts (link)
  • Modify the name of the location to be imported from "Camera Locations" to "Camera Loc" in asset_homepage.cy.ts (link)
  • Add some console logs to print the local storage before and after clearing the filters in user_manage.cy.ts (link)

konavivekramakrishna and others added 9 commits December 6, 2023 09:21
* Update sample_format_external_result_import URL

* Fix file path in config.json and refactor
handleDownload function in
ExternalResultUpload.tsx

* Fix download functionality in ExternalResultUpload
component
* Add DailyRoundsFilterModel interface and
DailyRoundsFilter component

* refactored dailyRoundList

* useQuery: Fix GET/HEAD cannot contain body issue

* Support for filtering by `taken_at` dt range

* Refactor DailyRoundsFilter and DailyRoundsList
components

* Refactor roundTypeOptions in DailyRoundsFilter
component

* Improve translations coverage and minor refactors

* update slugs for request

---------

Co-authored-by: rithviknishad <[email protected]>
* convert time to relative time

* change styling

* change margin

* add new classname
…/**) [5 out of 5 components] (#6596)

* replaced getUserDetails and getUserListSkills actions with useQuery

* replaced partialUpdateUser action with request

* replaced updatePassword action with request

* replaced dispatch with useQuery in UserFilter.tsx

* Bug Fix: UserFilter tried fetching district when district_id was not available

* addUser and checkUsername action replaced with request

* replaced useDispatch with request in UserAdd component

* replaced useDispatch with useQuery and request in SkillsSlideOver

* replaced useDispatch with useQuery and request in ManageUsers

* solved issue #6652 | passed user skills as props to SkillSelect

* removed unnecessary console logs

* re-added showAll as dependency to skillSearch

* removed unnecessary console logs

* replaced fetchDistrict request with useQuery and removed isLoading

* fixed error notification in ManageUsers

* removed unnecessary useState from ManageUsers

* code fixes in SkillsSlideOver

* code fixes in UserAdd

* code fix in UserFilter

* code fix in UserProfile

* removed redundant code

* added proper types and fixed redundant code

* removed redundant fireRequest actions

* fix http 301 redirect due to missing trailing slash

* Update TRes of userListFacility in src/Redux/api.tsx

Co-authored-by: Rithvik Nishad <[email protected]>

* resolved imports

---------

Co-authored-by: Rithvik Nishad <[email protected]>
Co-authored-by: Rithvik Nishad <[email protected]>
Co-authored-by: Mohammed Nihal <[email protected]>
* Page: support for auto collapse sidebar

* Adds utilities and `useOperateCamera` hook

* Adds reusable component: `NetworkSignal`

* stash

* Update camera controls

* rename files

* refactor

* refactor location filter

* Add location select popup

* Update location select logic

* update reponsiveness

* hide non working filters

* adjust z-index
* Added location type to location form

* fix adds location cypress test
@gigincg gigincg requested a review from a team as a code owner December 11, 2023 15:05
Copy link

vercel bot commented Dec 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2023 3:06pm

Copy link

netlify bot commented Dec 11, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit bd1f144
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6577254b1b80c70008f387b0
😎 Deploy Preview https://deploy-preview-6849--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@gigincg gigincg merged commit 801e8a0 into master Dec 11, 2023
9 of 19 checks passed
Copy link

@gigincg We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants